Skip to content

Fix for jQuery 3.x compatibility without using 3.x migrate plugin#147

Open
mgsmus wants to merge 1 commit into
markdalgleish:masterfrom
mgsmus:master
Open

Fix for jQuery 3.x compatibility without using 3.x migrate plugin#147
mgsmus wants to merge 1 commit into
markdalgleish:masterfrom
mgsmus:master

Conversation

@mgsmus

@mgsmus mgsmus commented Jan 13, 2017

Copy link
Copy Markdown

No description provided.

@chrisjeon

Copy link
Copy Markdown

@mgsmus It just looks like it's failing because the automated tests are not recognizing the jQuery 3 commands like on('load'). Try adding a jquery 3 version like 3.2.1 in this line https://github.com/markdalgleish/stellar.js/blob/master/Gruntfile.js#L48

Also, the version will have to be bumped up since it looks like this change will break previous versions of stellar.js running on older versions of jQuery.

@Thanaen

Thanaen commented Mar 26, 2019

Copy link
Copy Markdown

These changes have been approved, but I cannot find an associated release. Is the tavis-ci fail blocking a release? What's happening with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants