PDP-684: Adding TruffleHog Scan Workflow #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshp56
requested review from
GAdityaVarma,
Pragathi-28,
SameeraPriyathamTadikonda and
nagalakshmi2024
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a reusable TruffleHog secret scanning workflow to detect secrets in pull request changes. The workflow is integrated into the PR workflow template and supports optional file/folder exclusions.
Key changes:
- Added a new reusable workflow for TruffleHog secret scanning
- Integrated the TruffleHog scan job into the PR workflow template
- Implemented optional exclusion pattern support via
.trufflehog-excludefile
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| templates/pr-workflow.yml | Adds TruffleHog scan job to PR workflow template |
| .github/workflows/trufflehog-scan.yml | Creates reusable workflow for secret scanning with TruffleHog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "args=${ARGS}" >> "$GITHUB_OUTPUT" | ||
| - name: Secret Scanning | ||
| uses: trufflesecurity/trufflehog@main |
There was a problem hiding this comment.
Using '@main' for the TruffleHog action is not recommended for production workflows as it may introduce breaking changes without notice. Consider pinning to a specific version or commit SHA for stability and reproducibility.
Suggested change
| uses: trufflesecurity/trufflehog@main | |
| uses: trufflesecurity/trufflehog@v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested Reusable trufflehog scan workflow for secrets with test repo https://github.com/marklogic/copyrighttest/pull/36