Open
Conversation
I was silly enough to run geth and bor on the same node. These two binaries appear to use identical metrics for everything. The dashboard has been updated to include job=bor in order to distinguish geth metrics from bor activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was silly enough to run geth and bor on the same node. These two binaries appear to use identical metrics for everything. The dashboard has been updated to include job=bor in order to distinguish geth metrics from bor activity.
I updated to remove the specified dashboard since it's not available by default. The null field should default correctly to default datasource. A better approach is to variablize the datasource like heimdall dashboard, but that can happen in a followup PR.