mitmproxy addon: change config atomically - #272
Merged
Conversation
richvdh
force-pushed
the
rav/fix_mitm_addon_race
branch
3 times, most recently
from
August 6, 2026 15:52
b1b848e to
250b3e3
Compare
|
Use an `attrs` class to store the config, and change it atomically.
richvdh
force-pushed
the
rav/fix_mitm_addon_race
branch
from
August 6, 2026 16:37
250b3e3 to
0b0b2c1
Compare
andybalaam
approved these changes
Aug 7, 2026
andybalaam
left a comment
andybalaam
left a comment
Member
There was a problem hiding this comment.
Looks like a nice change, but it seems pretty remarkable if this race happens more often than 1 in a million runs?
Member
Author
|
Yeah, though we don't have any better suggestions for what could be causing it :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this will fix #249