use nanomorph & bel 5#71
Open
yoshuawuyts wants to merge 1 commit into
Open
Conversation
|
Hi! Excited about this, is there any approximation as to when this could be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes it so
yo-yoandchoostay compatible, and it becomes trivial to switch one out for the other. We switched tonanomorphwhenmorphdomintroduced several regressions in a minor version bump, introduced a tooling requirement and started adding features that pushed it beyond just dom diffing. So farnanomorphhas been quite alright, and I reckon it would make sense to keep the behavior the same (: Semver major for sure tho ✌️Changes
morphdomwithnanomorphbel@5Notable changes
nanomorph, so no more custom logic inyo-yo<input>elements must have avalue=${myValue}attribute set when copying, rather than the value from the old node being persisted. This way the DOM truly becomes a function of the data, rather than having parts of it that need clearing logic.onload()no longer ships inbel@5nanomorphdoesn't have a plugin system