Skip to content

[MOO-2459]: Upgrade eslint and react-hooks - #602

Merged
SrirangK merged 4 commits into
mx/11.12.xfrom
moo/MOO-2459/upgrade-eslint-11.12
Aug 20, 2026
Merged

[MOO-2459]: Upgrade eslint and react-hooks#602
SrirangK merged 4 commits into
mx/11.12.xfrom
moo/MOO-2459/upgrade-eslint-11.12

Conversation

@SrirangK

Copy link
Copy Markdown
Contributor

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 8, 9, 10
  • Did you update version and changelog? ❌
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

Feature specific

  • Comply with designs ✅ ❌
  • Comply with PM's requirements ✅ ❌

Please remove unnecessary emojis and sections and this comment before proceeding

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

Upgrade eslint and react hooks version to match that of pluggable widget tools

Relevant changes

Please add a high level explanation of what was changed and how the initial problem was solved

What should be covered while testing?

  1. Chart Widgets (4 widgets)

    Widgets: bar-chart-native, column-chart-native, line-chart-native, pie-doughnut-chart-native

  2. video-player-native

    Test scenarios:

    • Video loads and plays
    • Aspect ratio renders correctly
    • Controls show/hide correctly
    • Fullscreen mode works
    • Changing aspect ratio prop updates video dimensions
  3. gallery-native

    Test scenarios:

    • Load more button works (button pagination)
    • Virtual scrolling works (virtualScrolling pagination)
    • Pull to refresh works
    • Empty placeholder shows when no items
  4. listview-swipe-native

    Test scenarios:

    • Swipe left/right actions work
    • Swipe gestures trigger correct actions
    • Archive animation works
    • Toggle mode works
    • Buttons mode shows buttons correctly
  5. notifications-native

    Test scenarios:

    • Push notifications are received
    • Notification actions trigger correctly
    • Notification data (title, body, subtitle) displays correctly
    • Opening notification navigates correctly

Extra comments (optional)

Please add extra comments or delete the section if not required

@SrirangK
SrirangK requested a review from a team as a code owner August 14, 2026 08:28
Comment thread package.json Outdated
@MxKevinBeqo

Copy link
Copy Markdown
Contributor

Since they're quite a few hook changes, I would suggest let's make sure the tests failing here are not real legit failures (i.e. test locally if it's ok).

@SrirangK

Copy link
Copy Markdown
Contributor Author

Since they're quite a few hook changes, I would suggest let's make sure the tests failing here are not real legit failures (i.e. test locally if it's ok).

Web-view widget did not have any changes in this. But sure we can test locally

MxKevinBeqo
MxKevinBeqo previously approved these changes Aug 19, 2026
@SrirangK
SrirangK merged commit 6a8fa13 into mx/11.12.x Aug 20, 2026
180 of 187 checks passed
@SrirangK
SrirangK deleted the moo/MOO-2459/upgrade-eslint-11.12 branch August 20, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants