[MOO-2428] : Align dependency versions and pin every version in widgets 11-12-x - #606
Open
saurabhchavan1711 wants to merge 7 commits into
Conversation
MxKevinBeqo
reviewed
Aug 20, 2026
MxKevinBeqo
left a comment
MxKevinBeqo
left a comment
Contributor
There was a problem hiding this comment.
Worth checking also if the maestro screenshot comparison should be updated or not. I know they passed, but just to ensure that it did not pass because of the 5% image comparison tolerance.
Mainly suspicious about the Empty Star Icon, because in the rating.png it does not render an icon at all.
| : createElement(StarIcon, { size, color: selectedColor }); | ||
| const emptyStarIcon = this.props.emptyIcon?.value | ||
| ? (this.props.emptyIcon.value as any) | ||
| : createElement(StarIcon, { size, color }); |
Contributor
There was a problem hiding this comment.
In the case of empty Star, I see we are passing a color to use as fill. Could, or did we test having no fill color but only border? (basically replicating the empty glyph star icon look)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
This PR -