You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes flag to --modern-web-client, adds ENABLE_RSPACK_BUNDLER env passthrough
automation/run-e2e/lib/docker-utils.mjs
Adds enableRspackBundler flag to mxbuild command
automation/scripts/update-screenshots-local.mjs
Mirrors same flag additions for local screenshot updates
10x package.json files
Updates e2e script to Mendix 11.12.2 + MODERN_CLIENT + ENABLE_RSPACK_BUNDLER
Skipped (out of scope): dist/, pnpm-lock.yaml
CI checks: could not run gh pr checks in this environment — verify all checks pass before merging.
Findings
⚠️ Low — tree-node-web e2edev script left on old Mendix version
File:packages/pluggableWidgets/tree-node-web/package.json line 34
Note: The e2e script was updated to MENDIX_VERSION=11.12.2, but e2edev still pins MENDIX_VERSION=11.9.1. Developers running pnpm run e2edev locally will test against a different Mendix version than CI, which can mask incompatibilities.
Fix:"e2edev": "MENDIX_VERSION=11.12.2 run-e2e dev --with-preps"
⚠️ Low — docker-compose.yml accumulated excess leading whitespace
File:automation/run-e2e/docker/docker-compose.yml line 25
Note: The mxbuild command line gained roughly 20 extra leading spaces compared to surrounding lines. Functionally harmless inside the bash heredoc, but inconsistent with surrounding indentation.
Fix: Trim to match the indentation of surrounding lines.
Positives
Correct fix of the stale flag name --modern-client to --modern-web-client across all three code paths (ci.mjs, docker-utils.mjs, update-screenshots-local.mjs).
ENABLE_RSPACK_BUNDLER is handled consistently: boolean truthy check in JS, conditional shell expansion in the compose command.
Adding libgdiplus + libfontconfig1 to both mxbuild.Dockerfile and mxbuildRC.Dockerfile keeps them in sync; omitting one would have caused a split-brain failure between stable and RC builds.
No runtime widget code, XML schemas, or public APIs touched — CHANGELOG entries are correctly omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Test related change (New E2E test, test automation, etc.)
Description
This PR updates the used Mendix version to 11.12.2 and, through feature flags, enables React and rspack in the test projects.
What should be covered while testing?
E2E affected should continue to pass in the automation.