Skip to content

Remove shared chrome (docs) - #1299

Merged
gantoreno merged 7 commits into
masterfrom
gro-828-remove-shared-chrome
Aug 26, 2026
Merged

Remove shared chrome (docs)#1299
gantoreno merged 7 commits into
masterfrom
gro-828-remove-shared-chrome

Conversation

@gantoreno

@gantoreno gantoreno commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Fixes GRO-828

  • Removes the shared chrome implementation from Jekyll and creates standalone components
  • Removes the "Recent Posts" section from the navbar
  • Fetches GitHub stars dynamically

Amplify environment: https://gro-828-remove-shared-chrome.dkkh35gceu2po.amplifyapp.com/docs/latest

@linear

linear Bot commented Aug 25, 2026

Copy link
Copy Markdown

GRO-828

Comment thread _includes/chrome/scripts.html Fixed
@gantoreno
gantoreno requested a review from a team August 25, 2026 20:57
@gantoreno
gantoreno marked this pull request as ready for review August 25, 2026 20:57
@iethree

iethree commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

why keep the chrome/ directory structure? Why not just put everything in /docs/css and /docs/js ?

@bpander bpander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Spot-checked a bunch of pages and they all looked pixel perfect. And it looked like all the shared chrome was correctly removed and the css correctly ported.

🤔 Only potentially blocking issue is all the stuff still in public/{js,css}/ since a) it's misleading having different environments load different assets and b) because a lot of js files have two copies in this repo now.

ℹ️ Just making a note since I don't see it mentioned in the PR description or linear issue. There's a PRODIGIOUS amount of css that can be removed now. I think it makes sense to clean it up in a separate PR/issue, but it'd be good to link to the issue from this PR (and create it if it doesn't exist already).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These js files that were added already existed in the repo, just at public/js. And they weren't removed there so we have two copies of all of these now. Also, I still see a lot of references to "/js/...", e.g. cookie-consent.js loads "/js/marketing-hotjar.js" which in production will point at something different than local/staging.

Comment thread public/css/gdpr.css Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one css file left in public/css: public/css/inkeep.css. Its js file (inkeep.js) is also not accessible by /docs.

@gantoreno
gantoreno merged commit 526154b into master Aug 26, 2026
3 checks passed
@gantoreno
gantoreno deleted the gro-828-remove-shared-chrome branch August 26, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants