Remove shared chrome (docs) - #1299
Conversation
|
why keep the |
bpander
left a comment
There was a problem hiding this comment.
✅ Spot-checked a bunch of pages and they all looked pixel perfect. And it looked like all the shared chrome was correctly removed and the css correctly ported.
🤔 Only potentially blocking issue is all the stuff still in public/{js,css}/ since a) it's misleading having different environments load different assets and b) because a lot of js files have two copies in this repo now.
ℹ️ Just making a note since I don't see it mentioned in the PR description or linear issue. There's a PRODIGIOUS amount of css that can be removed now. I think it makes sense to clean it up in a separate PR/issue, but it'd be good to link to the issue from this PR (and create it if it doesn't exist already).
There was a problem hiding this comment.
These js files that were added already existed in the repo, just at public/js. And they weren't removed there so we have two copies of all of these now. Also, I still see a lot of references to "/js/...", e.g. cookie-consent.js loads "/js/marketing-hotjar.js" which in production will point at something different than local/staging.
There was a problem hiding this comment.
There's still one css file left in public/css: public/css/inkeep.css. Its js file (inkeep.js) is also not accessible by /docs.
Fixes GRO-828
Amplify environment: https://gro-828-remove-shared-chrome.dkkh35gceu2po.amplifyapp.com/docs/latest