GRO-686 Docs nav rework - #1315
Open
bpander wants to merge 7 commits into
Open
Conversation
bpander
marked this pull request as ready for review
September 2, 2026 13:20
bpander
force-pushed
the
gro-835-hot-reload-local-metabase
branch
from
September 2, 2026 13:29
c17596c to
b21f85c
Compare
bpander
force-pushed
the
gro-686-docs-nav
branch
from
September 2, 2026 13:30
3e296e6 to
85470b5
Compare
bpander
force-pushed
the
gro-686-docs-nav
branch
from
September 2, 2026 18:41
85470b5 to
b0f8823
Compare
…h and land it in this repo's _docs version folders
gantoreno
approved these changes
Sep 4, 2026
gantoreno
left a comment
gantoreno
left a comment
Contributor
There was a problem hiding this comment.
Already approved metabase/metabase#81703 (review), found no blocking issues here
One minor thing: fmt:check fails on NewDocsLayout.astro, run a formatting pass and should be good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRO-686
Makes the left nav read from
_docs/[version]/util/data/nav.ymlinstead of_data/docs/nav/[version].yml.This is a mainly a quality of life change. It keeps the nav data close to the source files and it eliminates the need to manually create a new nav file every time we release a new version.
Migrating the nav files from this repo to the metabase repo will be done in metabase/metabase#81703. Once all those auto-generated PRs are merged, I'll run
copy-navs-from-mb.shon this branch and delete it along with the _data/docs/nav folder.