Conversation
bc49697 to
04efdd2
Compare
35c184e to
d684615
Compare
4d75155 to
677cd19
Compare
|
I think this is now ready for reviewing. Though the current results with In terms of the implementation, thie current state hasn't reached an ideal state. The calculation of the The second thing is how we do "unfolding" in
Tests showed that the second way can generate fewer atoms and thus can save runtime from the model inference, while an extra NL calculation also costs time. My intuition is that which one is faster depends on the system size. Also maybe we need a tutorial about how to use this wrapper. |
f44cf5c to
b1b81da
Compare
3bece47 to
47d1c3a
Compare
8168eac to
61520b0
Compare
61520b0 to
3b77a9b
Compare
`model = HeatFlux.wrap(model)` will create a new model with the same outputs, and (multiple) extra outputs for the heat_flux, one for each energy variant.
3b77a9b to
b6c51bc
Compare
Closes #104
This is still in a very early stage and subjected to change.
TODO:
Remove Replace the dependency onvesin.metatomicwithvesin.torchand rebuild neighbor list from the un-unfolded system (Hard to build the neighboring information between the replica atoms, e.g. atoms in different image boxes. Andvesin.metatomicis not supposed to be used inmetatomic.)Contributor (creator of pull-request) checklist
Reviewer checklist