python-stdlib/collections-defaultdict: Add items() function.#1100
Open
agatti wants to merge 1 commit intomicropython:masterfrom
Open
python-stdlib/collections-defaultdict: Add items() function.#1100agatti wants to merge 1 commit intomicropython:masterfrom
agatti wants to merge 1 commit intomicropython:masterfrom
Conversation
This commit adds the `items()` functions to `collections.defaultdict`, acting as a simple proxy to the underlying dictionary container. This fixes micropython#350. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
items()functions tocollections.defaultdict, acting as a simple proxy to the underlying dictionary container.This fixes #350.
The package's version number was bumped up by 0.1.0 since a new function was added to the module.
Testing
The added tests in
python-stdlib/collections-defaultdictwere run successfully both on CPython (with a tweaked import harness) and on MicroPython's git master.Trade-offs and Alternatives
This adds 81 bytes to the final module. I'm a bit surprised it took that much, but unless it is documented that the backing dictionary can be accessed via
self.dwhen code runs on MicroPython, I don't see any other safe way to enumerate the contents [1].Generative AI
I did not use generative AI tools when creating this PR.
[1]
This trips up MicroPython, for example:
On current MicroPython's git master:
Whilst this works as expected on CPython 3.14 (and probably earlier versions too):