Switch E-Document Core to new PEPPOL App objects#7619
Open
Groenbech96 wants to merge 2 commits intomainfrom
Open
Switch E-Document Core to new PEPPOL App objects#7619Groenbech96 wants to merge 2 commits intomainfrom
Groenbech96 wants to merge 2 commits intomainfrom
Conversation
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
Groenbech96
force-pushed
the
private/magnushar/edoc-peppol-obsoletion
branch
3 times, most recently
from
0faeaa1 to
c70cc31
Compare
|
This change will probably break E Documents for Germany |
Contributor
Author
Yep. It should be caught when bcapps is uptaken in internal pr. Then we correct those places where test no longer work. |
…EPPOL App Replace references to obsoleted BaseApp PEPPOL codeunits and xmlports (PEPPOL Validation, PEPPOL Service Validation, PEPPOL Management, Serv. PEPPOL Management, Sales Invoice - PEPPOL BIS 3.0, Sales Cr.Memo - PEPPOL BIS 3.0) with their new PEPPOL App equivalents (PEPPOL30 Sales Validation, PEPPOL30 Service Validation, PEPPOL30, Sales Invoice - PEPPOL30, Sales Cr.Memo - PEPPOL30). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Groenbech96
force-pushed
the
private/magnushar/edoc-peppol-obsoletion
branch
from
c70cc31 to
a485711
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.Sales.PeppoltoMicrosoft.PeppolObject replacements:
Method renames:
CheckSalesInvoice/CheckSalesCreditMemo/CheckServiceInvoice/CheckServiceCreditMemo→ValidatePostedDocumentCheckServiceHeader→Run(uses OnRun trigger)GetTotals→GetTaxTotalsGetLineItemClassfiedTaxCategoryBIS→GetLineItemClassifiedTaxCategoryBIS(typo fix)ServPEPPOLMgt.MapServiceLineTypeToSalesLineType→PEPPOLMgt.MapServiceLineTypeToSalesLineType(merged into PEPPOL30)