Skip to content

Improve Get-RBASummary - #2581

Open
Shane Ferrell (Shanefe) wants to merge 6 commits into
mainfrom
Get_RBASummary_Improvements
Open

Improve Get-RBASummary#2581
Shane Ferrell (Shanefe) wants to merge 6 commits into
mainfrom
Get_RBASummary_Improvements

Conversation

@Shanefe

Copy link
Copy Markdown
Contributor

Add JSON output
Create a Safe text version of the output

Copilot AI lite review requested due to automatic review settings September 1, 2026 22:05
@Shanefe
Shane Ferrell (Shanefe) requested a review from a team as a code owner September 1, 2026 22:05
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Confirmed runtime issues (undefined variable reference and Place collector result-shape handling) should be addressed to prevent failures and inconsistent report output.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR enhances Get-RBASummary.ps1 to produce a structured JSON report alongside the human-readable transcript, adds privacy-mode handling (sanitized/targeted/full), and introduces comprehensive Pester coverage and updated documentation for the new behaviors.

Changes:

  • Added best-effort collectors, structured error capture, identity sanitization, and JSON report generation to Calendar/Get-RBASummary.ps1.
  • Added a full Pester test suite for JSON schema/status, targeted meeting correlation, and sanitization behavior.
  • Expanded the markdown documentation to describe requirements, outputs, privacy modes, and targeted meeting search semantics.
File summaries
File Description
docs/Calendar/Get-RBASummary.md Documents new JSON output, privacy modes, and targeted meeting search behavior.
Calendar/Get-RBASummary.ps1 Implements best-effort collection, safe/sanitized reporting, targeted meeting extraction, and JSON export.
Calendar/Tests/Get-RBASummary.Tests.ps1 Adds Pester tests validating collection flow, sanitization, targeted meeting extraction, and output files.
Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Calendar/Tests/Get-RBASummary.Tests.ps1 Outdated
Comment thread Calendar/Get-RBASummary.ps1 Outdated
Comment thread Calendar/Get-RBASummary.ps1 Outdated
Comment thread Calendar/Get-RBASummary.ps1 Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants