Improve Get-RBASummary - #2581
Open
Shane Ferrell (Shanefe) wants to merge 6 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Confirmed runtime issues (undefined variable reference and Place collector result-shape handling) should be addressed to prevent failures and inconsistent report output.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR enhances Get-RBASummary.ps1 to produce a structured JSON report alongside the human-readable transcript, adds privacy-mode handling (sanitized/targeted/full), and introduces comprehensive Pester coverage and updated documentation for the new behaviors.
Changes:
- Added best-effort collectors, structured error capture, identity sanitization, and JSON report generation to
Calendar/Get-RBASummary.ps1. - Added a full Pester test suite for JSON schema/status, targeted meeting correlation, and sanitization behavior.
- Expanded the markdown documentation to describe requirements, outputs, privacy modes, and targeted meeting search semantics.
File summaries
| File | Description |
|---|---|
| docs/Calendar/Get-RBASummary.md | Documents new JSON output, privacy modes, and targeted meeting search behavior. |
| Calendar/Get-RBASummary.ps1 | Implements best-effort collection, safe/sanitized reporting, targeted meeting extraction, and JSON export. |
| Calendar/Tests/Get-RBASummary.Tests.ps1 | Adds Pester tests validating collection flow, sanitization, targeted meeting extraction, and output files. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSON output
Create a Safe text version of the output