Skip to content
This repository was archived by the owner on Jun 10, 2026. It is now read-only.

Support net standard (v1.1)#10

Open
danzel wants to merge 2 commits into
microsoft:masterfrom
torutek:SupportNETStandard
Open

Support net standard (v1.1)#10
danzel wants to merge 2 commits into
microsoft:masterfrom
torutek:SupportNETStandard

Conversation

@danzel

@danzel danzel commented Nov 23, 2017

Copy link
Copy Markdown

This includes and superseeds #7

Update the package to target NET Standard 1.1 so it can be used by normal .net framework and .net core projects.

This PR drops the targetted version of standard to 1.1 so the package can be used by net framework 4.5 (previous PR was 1.4, so .net 4.6 was required)

@msftclas

msftclas commented Nov 23, 2017

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@danzel

danzel commented Nov 23, 2017

Copy link
Copy Markdown
Author

@huxuan It'd be cool to get this merged and nuget'd, then I can send the same for the Face API to fix microsoft/Cognitive-Face-Windows#39

@huxuan

huxuan commented Nov 23, 2017

Copy link
Copy Markdown

@danzel I am not the project owner for this, but I will ping some guys that might be able to handle this.

@danzel

danzel commented Nov 23, 2017

Copy link
Copy Markdown
Author

Ah sorry for the ping then. Thanks :)

@cthrash

cthrash commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

@chsienki - can you give me a hand on this? I'm not quite sure what this change means for, say, UWP. Also, are we possibly going to break Xamarin projects? Currently the supported profile is Profile259, which means .NET Framework 4.5, Windows 8, Windows Phone 8.1, Windows Phone Silverlight 8. Is .NET core a proper lowest-common denominator?

@chsienki

Copy link
Copy Markdown
Contributor

netstandard1.1 supports everything but Windows Phone Silverlight 8. (See https://docs.microsoft.com/en-us/dotnet/standard/net-standard)

I think at this point its probably fair to say we no longer support WP8.0, but this is technically a breaking change, which would require upping the package version to 2.0.

As long as we change the version number I don't have any problems with it, as downstream packages will then have to opt-in to the netstandard version, and any others won't be affected. We probably want to bump the major version on the down streams too, as they pull in support, and ripple the netstandard update across them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants