Use same obsolete messages as 'WinRT.Runtime' in projection assemblies #2195
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed WindowsRuntimeConstants from internal to public, marked it as obsolete with diagnostic information, and added EditorBrowsable(Never) to discourage usage. This improves API clarity and guides developers away from using internal implementation details.
Updated the [Obsolete] attribute in generated code to include message, DiagnosticId, and UrlFormat from WindowsRuntimeConstants. This provides more detailed diagnostic information and guidance for deprecated members.
There was a problem hiding this comment.
Pull request overview
This PR updates the obsolete attribute usage in generated projection assemblies to match the detailed format used in the 'WinRT.Runtime' assembly, improving consistency across the codebase.
Changes:
- Updated generated code to use detailed Obsolete attributes with message, diagnostic ID, and URL format
- Changed WindowsRuntimeConstants visibility from internal to public to enable access from projection assemblies
- Applied Obsolete and EditorBrowsable attributes to WindowsRuntimeConstants class itself
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cswinrt/code_writers.h | Updated code generation to emit detailed Obsolete attributes (with message, diagnostic ID, and URL format) for IsOverridableInterface and HasUnwrappableNativeObjectReference methods in generated projection code |
| src/WinRT.Runtime2/Properties/WindowsRuntimeConstants.cs | Changed class visibility to public, added necessary using statements, and applied Obsolete/EditorBrowsable attributes to the class itself to match the pattern of other private implementation detail classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manodasanW
approved these changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. This just makes things more consistent.