Fix DS126858 false positive on --nomd5 and similar disable flags #722
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule DS126858 (Weak/Broken Hash Algorithm) was flagging cases where MD5 is explicitly disabled, e.g.
makeself --sha256 --nomd5.Changes
\bno(matchesnomd5,--nomd5)\bno-(matchesno-md5)\bno_(matchesno_md5)\bdisable_(matchesdisable_md5_check)must-not-matchtest casesPattern
The word boundaries ensure edge cases like
xnomd5are still flagged while legitimate disable flags are excluded.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.