Skip to content

fix(action-schema): support boolean literal values - #3267

Merged
Hillary Mutisya (hillary-mutisya) merged 5 commits into
microsoft:mainfrom
feiiiiii5:codex/fix-boolean-literal-schemas
Nov 11, 2026
Merged

Hillary Mutisya (hillary-mutisya) merged 5 commits into
microsoft:mainfrom
feiiiiii5:codex/fix-boolean-literal-schemas

Conversation

@feiiiiii5

Copy link
Copy Markdown
Contributor

The action-schema parser accepts true and false literal types, but validation rejects their matching boolean values and JSON Schema generation emits invalid type: "true" / type: "false" values. Validate the exact literal and generate a boolean schema constrained by a one-value enum. Explicit string coercion follows the existing opt-in behavior.

Tests cover both literals through the public parsing, validation and JSON Schema APIs, including aliases, arrays, optional fields, unions and rejection of the opposite value.

Validation on Node 26.13.0:

  • All 12 regressions fail on the original base and pass with the fix.
  • Package build and all five actionSchema suites pass: 350 passed, 62 pre-existing skipped cases.
  • Changed-file Prettier, lint and complexity ratchets, and the test-debt gate pass. Matching sparse-tree dependency graphs retain the same 15 existing cycles (751 files); the full-workspace circular gate was not run locally.
  • Frozen lockfile unchanged.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@hillary-mutisya

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@hillary-mutisya

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@feiiiiii5

Copy link
Copy Markdown
Contributor Author

Local check on 8e86402: the full @typeagent/action-schema suite, including regen.spec against the default agents, passes (5 suites, 350 passed, 62 skipped). I could not reproduce a schema-side failure. Main b833369 passed the same smoke job at 00:05Z (build 142709), while this head failed at 00:12Z (build 142716), so the difference may be the live Azure/shell step rather than the four schema files. Could you share the failing step (CLI startup vs live shell) or rerun the smoke job? I don't have access to the Azure logs.

@hillary-mutisya
Hillary Mutisya (hillary-mutisya) merged commit 9b2dccb into microsoft:main Nov 11, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants