.NET: Rename local variables in LocalEvaluator.cs to follow C# guidelines#5970
Open
XiongHaoTrigger wants to merge 1 commit into
Open
.NET: Rename local variables in LocalEvaluator.cs to follow C# guidelines#5970XiongHaoTrigger wants to merge 1 commit into
XiongHaoTrigger wants to merge 1 commit into
Conversation
The local variables in LocalEvaluator.cs violated the team's C# coding guidelines. Renamed these variables to improve code readability and consistency.
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates LocalEvaluator to follow C# local-variable naming conventions by renaming a locally-scoped variable used during metric evaluation, without changing behavior.
Changes:
- Renamed
EvalCheckResult→evalCheckResultwithinEvaluateAsyncto match standard C# camelCase local variable style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While reading the source code, I noticed that the naming of local variables here does not comply with C# guidelines. This change is purely formatting and does not affect any functionality.
Description
The local variables in
dotnet/src/Microsoft.Agents.AI/Evaluation/LocalEvaluator.csviolated the C# coding guidelines. Renamed these variables to improve code readability and consistency.Contribution Checklist