Skip to content

Python: track agent-hooks feature usage #7558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Evan Mattson (moonbox3) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: track agent-hooks feature usage #7558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/specs/feature-usage-bit-registry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ only to approved first-party endpoints.
| 15 | `core.in_memory_skills_source` | In-memory / programmatic skills | `agent_framework.InMemorySkillsSource` |
| 16 | `core.mcp_skills_source` | MCP-backed skills | `agent_framework.MCPSkillsSource` |
| 17 | `core.session_store` | Agent session store | `agent_framework.SessionStore` / `FileSessionStore` |
| 18–31 | _reserved_ | core growth | — |
| 18 | `core.agent_hooks` | Agent Hooks middleware | `agent_framework.create_agent_hooks_middleware` |
| 19–31 | _reserved_ | core growth | — |
| 32 | `orchestration.sequential` | Sequential orchestration | `agent_framework_orchestrations.SequentialBuilder` |
| 33 | `orchestration.concurrent` | Concurrent orchestration | `agent_framework_orchestrations.ConcurrentBuilder` |
| 34 | `orchestration.group_chat` | Group-chat orchestration | `agent_framework_orchestrations.GroupChatBuilder` |
Expand Down
2 changes: 2 additions & 0 deletions python/packages/core/agent_framework/_agent_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
_current_run_identity, # pyright: ignore[reportPrivateUsage]
_RunPersistenceGate, # pyright: ignore[reportPrivateUsage]
)
from ._telemetry import FeatureIndex, mark_feature_used
from ._types import (
AgentResponse,
AgentResponseUpdate,
Expand Down Expand Up @@ -1610,6 +1611,7 @@ def create_agent_hooks_middleware_from_emitter(


def _build_bundle(config: _AgentHooksConfig) -> MiddlewareBundle:
mark_feature_used(FeatureIndex.CORE_AGENT_HOOKS)
return MiddlewareBundle([
_AgentHooksAgentMiddleware(config),
_AgentHooksChatMiddleware(config),
Expand Down
1 change: 1 addition & 0 deletions python/packages/core/agent_framework/_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ class FeatureIndex(IntEnum):
CORE_IN_MEMORY_SKILLS_SOURCE = 15
CORE_MCP_SKILLS_SOURCE = 16
CORE_SESSION_STORE = 17
CORE_AGENT_HOOKS = 18


# This environment variable is reserved by the Foundry hosting environment to
Expand Down
18 changes: 18 additions & 0 deletions python/packages/core/tests/core/test_agent_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import pytest

import agent_framework
import agent_framework._telemetry as telemetry
from agent_framework import (
Agent,
AgentContext,
Expand Down Expand Up @@ -155,6 +156,23 @@ def points(records: list[Any]) -> list[str]:
# region Factory validation


@pytest.mark.parametrize("factory_kind", ["managed", "host_owned"])
@requires_sdk
def test_agent_hooks_factories_activate_feature_telemetry(factory_kind: str, monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.setattr(telemetry, "_feature_mask", 0)
monkeypatch.setattr(telemetry, "IS_TELEMETRY_ENABLED", True)
monkeypatch.setenv(telemetry.FEATURE_MASK_DISABLED_ENV_VAR, "false")

if factory_kind == "managed":
create_agent_hooks_middleware([AllowGuard()])
else:
emitter = InterceptionEmitter().register(AllowGuard())
builder = AgentContextBuilder(agent_id="a", framework="agent-framework", session_id="s")
create_agent_hooks_middleware_from_emitter(emitter, builder)

assert telemetry.get_feature_token() == "v1.40000"


@requires_sdk
async def test_factory_requires_interceptors() -> None:
with pytest.raises(ValueError, match="at least one interceptor"):
Expand Down
Loading