-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(react-range-slider-preview): scaffold package and add spec #35440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-range-slider-preview): scaffold package and add spec #35440
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
packages/react-components/react-range-slider-preview/library/docs/Spec.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-range-slider-preview/library/docs/Spec.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-range-slider-preview/library/docs/Spec.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-range-slider-preview/library/docs/Spec.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-range-slider-preview/library/docs/Spec.md
Outdated
Show resolved
Hide resolved
|
We also discussed this within the team and agreed that it would be better to add this to existing Slider component. So you better will be to create a new feature branch and change this PR to target that branch instead of master, locally reset this commit changes except the spec file, then run UPD: I forgot that |
9301b55 to
4065fac
Compare
4065fac to
9301b55
Compare
9301b55 to
30ad97e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I'd suggest to revisit is the accessibility shape of the DOM. In the proposed markup, the input type="range" elements are aria-hidden and tabindex="-1", and the thumbs are exposed as div role="slider". Let's check this approach
6d7086d
into
microsoft:react-range-slider
PR Summary