Skip to content

Conversation

@soniaboller
Copy link

PR Summary

  • This PR adds the scaffolding and spec for a new RangeSlider component
  • This is a separate control from current range-slider because it does not support multi values.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

📊 Bundle size report

✅ No changes found

@github-actions
Copy link

Pull request demo site: URL

@soniaboller soniaboller marked this pull request as ready for review November 10, 2025 19:13
@mainframev
Copy link
Contributor

mainframev commented Nov 25, 2025

@soniaboller

We also discussed this within the team and agreed that it would be better to add this to existing Slider component. So you better will be to create a new feature branch and change this PR to target that branch instead of master, locally reset this commit changes except the spec file, then run yarn create-component to add RangeSlider to react-slider to create a boilerplate code for new component

UPD: I forgot that create-component is intended for preview packages only. You can resolve the lint errors by adding the necessary exports to the react-components suite package and updating the story imports to pull from react-components

@mainframev mainframev changed the base branch from master to react-range-slider November 25, 2025 23:46
@soniaboller soniaboller requested a review from a team as a code owner December 1, 2025 17:13
@soniaboller soniaboller force-pushed the feat/react-range-slider-preview-scaffold branch from 9301b55 to 4065fac Compare December 1, 2025 18:46
@soniaboller soniaboller requested review from a team and Jacqueline-ms as code owners December 1, 2025 18:46
@soniaboller soniaboller force-pushed the feat/react-range-slider-preview-scaffold branch from 4065fac to 9301b55 Compare December 1, 2025 18:50
@github-actions github-actions bot removed the NX: core label Dec 1, 2025
@mainframev mainframev deleted the branch microsoft:react-range-slider December 1, 2025 22:19
@mainframev mainframev closed this Dec 1, 2025
@mainframev mainframev reopened this Dec 1, 2025
@soniaboller soniaboller force-pushed the feat/react-range-slider-preview-scaffold branch from 9301b55 to 30ad97e Compare December 1, 2025 22:27
Copy link
Contributor

@mainframev mainframev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'd suggest to revisit is the accessibility shape of the DOM. In the proposed markup, the input type="range" elements are aria-hidden and tabindex="-1", and the thumbs are exposed as div role="slider". Let's check this approach

@mainframev mainframev merged commit 6d7086d into microsoft:react-range-slider Dec 17, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants