Skip to content

Conversation

@dmytrokirpa
Copy link
Contributor

Previous Behavior

Button components used the getIntrinsicElementProps helper to filter-out non-HTML props which adds https://github.com/microsoft/fluentui/blob/feat/react-button-reduce-bundle-size/packages/react-components/react-utilities/src/utils/properties.ts via getIntrinsicElementProps/getNativeElementProps

image

New Behavior

Make sure we filter-out custom props inside a component and passthrough only valid HTML props

image

Related Issue(s)

  • Fixes #

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-breadcrumb
@fluentui/react-breadcrumb - package
115.625 kB
31.709 kB
115.626 kB
31.723 kB
1 B
14 B
react-button
Button
38.098 kB
10.605 kB
34.737 kB
9.318 kB
-3.361 kB
-1.287 kB
react-button
CompoundButton
44.982 kB
11.967 kB
41.615 kB
10.672 kB
-3.367 kB
-1.295 kB
react-button
MenuButton
43.038 kB
12.045 kB
39.641 kB
10.706 kB
-3.397 kB
-1.339 kB
react-button
SplitButton
51.803 kB
13.67 kB
48.44 kB
12.372 kB
-3.363 kB
-1.298 kB
react-button
ToggleButton
55.016 kB
12.439 kB
51.65 kB
11.146 kB
-3.366 kB
-1.293 kB
react-charts
AreaChart
402.827 kB
123.084 kB
402.827 kB
123.092 kB

8 B
react-charts
DeclarativeChart
720.516 kB
208.412 kB
720.516 kB
208.337 kB

-75 B
react-charts
DonutChart
298.828 kB
89.101 kB
298.828 kB
89.075 kB

-26 B
react-charts
FunnelChart
290.083 kB
85.929 kB
290.083 kB
85.949 kB

20 B
react-charts
GanttChart
384.697 kB
116.219 kB
384.732 kB
116.184 kB
35 B
-35 B
react-charts
GaugeChart
313.705 kB
92.734 kB
313.705 kB
92.723 kB

-11 B
react-charts
GroupedVerticalBarChart
392.719 kB
118.848 kB
392.719 kB
118.895 kB

47 B
react-charts
HeatMapChart
386.777 kB
117.935 kB
386.777 kB
117.942 kB

7 B
react-charts
HorizontalBarChart
296.449 kB
87.009 kB
296.449 kB
87.011 kB

2 B
react-charts
Legends
235.555 kB
69.356 kB
235.588 kB
69.376 kB
33 B
20 B
react-charts
LineChart
412.115 kB
124.516 kB
412.115 kB
124.511 kB

-5 B
react-charts
ScatterChart
392.006 kB
118.772 kB
392.006 kB
118.782 kB

10 B
react-charts
VerticalBarChart
427.051 kB
123.837 kB
427.051 kB
123.843 kB

6 B
react-charts
VerticalStackedBarChart
398.948 kB
119.78 kB
398.948 kB
119.75 kB

-30 B
react-components
react-components: Button, FluentProvider & webLightTheme
70.189 kB
20.037 kB
70.234 kB
20.047 kB
45 B
10 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
237.194 kB
68.545 kB
237.195 kB
68.547 kB
1 B
2 B
react-components
react-components: entire library
1.284 MB
321.69 kB
1.284 MB
321.711 kB
8 B
21 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
105.924 kB
29.733 kB
react-card
Card
98.592 kB
27.856 kB
react-card
CardFooter
13.549 kB
5.411 kB
react-card
CardHeader
16.082 kB
6.279 kB
react-card
CardPreview
13.633 kB
5.547 kB
react-charts
HorizontalBarChartWithAxis
63 B
83 B
react-charts
SankeyChart
199.518 kB
61.371 kB
react-charts
Sparkline
91.385 kB
28.704 kB
react-components
react-components: FluentProvider & webLightTheme
43.528 kB
14.148 kB
react-dialog
Dialog (including children components)
102.738 kB
30.646 kB
react-message-bar
MessageBar (all components)
24.057 kB
8.884 kB
react-portal-compat
PortalCompatProvider
8.386 kB
2.624 kB
react-tag-picker
@fluentui/react-tag-picker - package
187.327 kB
56.145 kB
react-teaching-popover
TeachingPopover
101.867 kB
30.488 kB
react-timepicker-compat
TimePicker
108.943 kB
35.995 kB
react-tree
FlatTree
148.292 kB
42.393 kB
react-tree
PersonaFlatTree
150.12 kB
42.772 kB
react-tree
PersonaTree
146.181 kB
41.588 kB
react-tree
Tree
144.361 kB
41.232 kB
🤖 This report was generated against e7c49a16e9f62e150d73b5a16d2dcae101462696

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Pull request demo site: URL

@dmytrokirpa dmytrokirpa marked this pull request as ready for review December 9, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants