fix(web-components): handle spellcheck values in TextInput and TextArea - #36500
Open
John Kreitlow (radium-v) wants to merge 2 commits into
Open
fix(web-components): handle spellcheck values in TextInput and TextArea#36500John Kreitlow (radium-v) wants to merge 2 commits into
John Kreitlow (radium-v) wants to merge 2 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Zacky Ma (marchbox)
approved these changes
Aug 4, 2026
John Kreitlow (radium-v)
force-pushed
the
users/radium-v/wc-fix-spellcheck
branch
from
August 5, 2026 15:40
b4812b7 to
3f888b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Browser support for propagating the global
spellcheckattribute across shadow roots is inconsistent: Chromium and WebKit inherit it across the boundary, while Firefox does not.TextInputconverted non-stringspellcheckproperty values tonull, which could throw during attribute reflection.TextAreatreatedspellcheckas a boolean attribute, causing values such asspellcheck="false"to enable spell checking. These issues could leave the internal control with different behavior across browsers or after SSR hydration.New Behavior
TextInputandTextAreaexplicitly propagate normalized, enumeratedspellcheckvalues to their internal controls instead of relying on browser-specific shadow-root inheritance.Boolean property values are preserved, nullish values safely remove the attribute, and
TextAreasynchronizes its default state during hydration. Coverage includes attribute and property updates, removal, defaults, CSR, and SSR across Chromium, Firefox, and WebKit.Related Issue(s)
spellcheckattribute whatwg/html#10050