fix: do not hang API calls after a page crash#41327
Open
dgozman wants to merge 1 commit into
Open
Conversation
Reject pending protocol calls when the page crashes (Chromium/Firefox), the same way we already do on close, so in-flight actions and assertions fail fast instead of hanging. Unify the page crash/close lifecycle and allow page.close() to work after a crash. Fixes: microsoft#31907
Contributor
Test results for "MCP"7341 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 3 flaky39617 passed, 749 skipped Merge workflow run. |
yury-s
approved these changes
Jun 16, 2026
| return this.sendEvenAfterCrash(method, params); | ||
| } | ||
|
|
||
| async sendEvenAfterCrash<T extends keyof Protocol.CommandParameters>( |
Member
There was a problem hiding this comment.
this name is confusing, is the intent to be able to send closePage even after the page has crashed?
| // The page content target is gone (e.g. after a crash) and the orphaned page | ||
| // proxy cannot be destroyed via the protocol. Finalize the close locally so | ||
| // page.close() resolves and the page is reported closed. | ||
| // TODO: the proper fix is in the browser - destroy the orphaned page proxy. |
Member
There was a problem hiding this comment.
Let's implement it in this change?
Collaborator
Author
There was a problem hiding this comment.
I think this needs a browser side change. We can wait with landing this PR until the browser is fixed though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.close()work after a crash.Fixes #31907