test(webkit): update webkit-wsl launch expectations for executablePath#41334
Open
yury-s wants to merge 1 commit into
Open
test(webkit): update webkit-wsl launch expectations for executablePath#41334yury-s wants to merge 1 commit into
yury-s wants to merge 1 commit into
Conversation
webkit-wsl now accepts executablePath (it no longer throws), so an invalid path is rejected with the standard "Failed to launch ... doesn't exist". Reference: microsoft#37036
Contributor
Test results for "MCP"2 failed 7352 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky39601 passed, 743 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webkit-wslnow acceptsexecutablePath(feat(webkit): support executablePath for the webkit-wsl channel #41325 removed theCannot specify executablePaththrow), sobrowsertype-launch.spec.tsshould no longer expect that message — an invalid path is now rejected with the standardFailed to launch … doesn't exist.Reference: #37036