fix(firefox): fix test timeouts after #41224#41336
Open
dcrousso wants to merge 1 commit into
Open
Conversation
limit when `Page.navigationCommitted` should be treated as a `Page.sameDocumentNavigation` to only if the `url` and `frameId` match a known active navigation without these, we end up rerouting more than intended to handle the original process-swap scenario
Contributor
Test results for "MCP"2 failed 7352 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky39599 passed, 743 skipped Merge workflow run. |
Contributor
Test results for "tests others"1 fatal errors, not part of any test 1 flaky20001 passed, 647 skipped Merge workflow run. |
Contributor
Test results for "tests 2"1 failed 23 flaky93612 passed, 4115 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
limit when
Page.navigationCommittedshould be treated as aPage.sameDocumentNavigationto only if theurlandframeIdmatch a known active navigationwithout these, we end up rerouting more than intended to handle the original process-swap scenario
should fix #41224 (comment)