Skip to content

Remove JSBigStringResourceDll, and unify WebsocketResource #16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoates-ms merged 2 commits into from
May 20, 2026
Merged

Remove JSBigStringResourceDll, and unify WebsocketResource #16159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722aeff
Remove JSBigStringResourceDll, and unify WebsocketResource
acoates-ms May 19, 2026
747aace
Change files
acoates-ms May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-5af495be-fb9e-41ac-b5db-3e57961ae073.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Remove JSBigStringResourceDll, and unify WebsocketResource",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
38 changes: 0 additions & 38 deletions vnext/Desktop/JSBigStringResourceDll.cpp
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions vnext/Desktop/JSBigStringResourceDll.h
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions vnext/Desktop/React.Windows.Desktop.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,10 @@
</ItemDefinitionGroup>
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\ReactCommunity.cpp.props" />
<ItemGroup>
<ClCompile Include="JSBigStringResourceDll.cpp" />
<ClCompile Include="module.g.cpp" />
<ClCompile Include="pch.cpp">
<PrecompiledHeader>Create</PrecompiledHeader>
</ClCompile>
<ClCompile Include="WebSocketResourceFactory.cpp" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\Microsoft.ReactNative\DynamicReader.h">
Expand Down Expand Up @@ -179,7 +177,6 @@
</ClInclude>
<ClInclude Include="..\Microsoft.ReactNative\RedBoxErrorFrameInfo.h" />
<ClInclude Include="..\Microsoft.ReactNative\RedBoxErrorInfo.h" />
<ClInclude Include="JSBigStringResourceDll.h" />
<ClInclude Include="pch.h" />
</ItemGroup>
<ItemGroup>
Expand Down
6 changes: 0 additions & 6 deletions vnext/Desktop/React.Windows.Desktop.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@
<ClCompile Include="ABI\TestController.cpp">
<Filter>ABI</Filter>
</ClCompile>
<ClCompile Include="JSBigStringResourceDll.cpp">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="module.g.cpp">
<Filter>Generated Files</Filter>
</ClCompile>
Expand All @@ -66,9 +63,6 @@
</ClInclude>
</ItemGroup>
<ItemGroup>
<ClInclude Include="JSBigStringResourceDll.h">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="Modules\TimingModule.h">
<Filter>Header Files\Modules</Filter>
</ClInclude>
Expand Down
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@
</ClInclude>
</ItemGroup>
<ItemGroup>
<ClCompile Include="Modules\CreateModules.cpp" />
<ClCompile Include="Pch\pch.cpp">
<PrecompiledHeader>Create</PrecompiledHeader>
</ClCompile>
Expand Down
3 changes: 0 additions & 3 deletions vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,6 @@
<ClCompile Include="Utils\ValueUtils.cpp">
<Filter>Utils</Filter>
</ClCompile>
<ClCompile Include="Modules\CreateModules.cpp">
<Filter>Modules</Filter>
</ClCompile>
<ClCompile Include="Views\FrameworkElementTransferProperties.cpp" />
<ClCompile Include="Views\ReactViewInstance.cpp" />
</ItemGroup>
Expand Down
24 changes: 0 additions & 24 deletions vnext/Microsoft.ReactNative/Modules/CreateModules.cpp
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion vnext/Scripts/OfficeReact.Win32.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@

<!-- Required for win32 -->
<file src="$nugetroot$\inc\Shared\DevServerHelper.h" target="inc"/>
<file src="$nugetroot$\inc\ReactWin32\JSBigStringResourceDll.h" target="inc"/>
<file src="$nugetroot$\inc\react-native-win32.x64.def" target="inc"/>
<file src="$nugetroot$\inc\react-native-win32.x86.def" target="inc"/>

Expand Down
1 change: 1 addition & 0 deletions vnext/Shared/Shared.vcxitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@
<ClCompile Include="$(MSBuildThisFileDirectory)V8JSIRuntimeHolder.cpp">
<ExcludedFromBuild Condition="'$(UseV8)' != 'true'">true</ExcludedFromBuild>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)WebSocketResourceFactory.cpp" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="$(MSBuildThisFileDirectory)..\codegen\react\components\rnwcore\EventEmitters.h" />
Expand Down
0 vnext/Desktop/WebSocketResourceFactory.cpp → vnext/Shared/WebSocketResourceFactory.cpp
View file
Open in desktop
File renamed without changes.
Loading