[rush] Avoid unnecessary package manager install lock#5844
Open
EscapeB wants to merge 1 commit into
Open
Conversation
EscapeB
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
| path: `${tempFolderPath}/rush-global`, | ||
| nodeSpecificPath: `${tempFolderPath}/rush-global/node-${process.version}` | ||
| } as RushGlobalFolder; | ||
| const packageManagerToolFolder: string = path.join(rushGlobalFolder.nodeSpecificPath, 'pnpm-10.27.0'); |
Contributor
There was a problem hiding this comment.
How is this version of pnpm selected, and when was it installed? I don't see anything mocking the file system checks to ensure that the version exists and/or writing files to do so.
| packageManagerToolVersion: '10.27.0' | ||
| } as RushConfiguration; | ||
|
|
||
| await InstallHelpers.ensureLocalPackageManagerAsync(rushConfiguration, rushGlobalFolder, 1, true); |
Contributor
There was a problem hiding this comment.
Ensure that the lockAcquireSpy returns false so that the test doesn't try to actually install the package if something goes wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the package-manager install lock optimization from #5830 into a standalone change.
Rush now skips acquiring the global package manager install lock when the requested package manager is already installed and no matching install lock file exists. If a lock file exists, Rush still acquires the lock to preserve stale/dirty recovery behavior.
Testing
node common/scripts/install-run-rush.js test --to @microsoft/rush-lib --verbose