Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python: samples: add Synap long-term memory plugin sample #14008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Python: samples: add Synap long-term memory plugin sample #14008
Changes from all commits
05e7e40209e186File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick:
get_chat_message_contentreturnsChatMessageContent | None. IfresponseisNone,add_messagewill raiseTypeError. TheNonepath is effectively dead code today (markedpragma: no cover) and other samples also skip this guard, so this is non-blocking—but adding a guard would be more defensive.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR describes persistent cross-session memory, but
historystill contains the user's original fact from the first turn. The model can answer from short-term chat history even ifsynap-store_memory/synap-search_memoryare never invoked. Re-create the ChatHistory before the recall turn to actually exercise the long-term memory path.Uh oh!
There was an error while loading. Please reload this page.