Python: fix(redis): pass collection prefix as a list#14012
Open
MukundaKatta wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Redis search index creation by passing the IndexDefinition.prefix as a list (instead of a string), matching the expected Redis client API and preventing incorrect prefix handling.
Changes:
- Update Redis connector index creation to pass
prefix=[f"{collection_name}:"]toIndexDefinition. - Update the existing unit test that creates an
IndexDefinitionmanually to use a list prefix. - Add a unit test asserting
ensure_collection_exists()constructsIndexDefinitionwith a single-item prefix list for both HASH and JSON collections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/semantic_kernel/connectors/redis.py | Passes collection prefix to IndexDefinition as a list during index creation. |
| python/tests/unit/connectors/memory/test_redis_store.py | Updates manual index-definition test and adds coverage ensuring list-prefix behavior for both collection types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.