.Net: Fix TextChunker token-counted paragraph merge#14015
Open
pragnyanramtha wants to merge 2 commits into
Open
.Net: Fix TextChunker token-counted paragraph merge#14015pragnyanramtha wants to merge 2 commits into
pragnyanramtha wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a bug in TextChunker where the final short-paragraph merge step could exceed the configured token budget when a custom TokenCounter was used.
Changes:
- Validate the merged paragraph against the token budget before applying the merge.
- Skip the merge when the candidate exceeds the limit.
- Add unit tests covering both the over-limit and under-limit scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/SemanticKernel.Core/Text/TextChunker.cs | Guard the final paragraph merge with a token-count check using the configured counter. |
| dotnet/src/SemanticKernel.UnitTests/Text/TextChunkerTests.cs | Add regression tests for the over-limit and still-fits merge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13713.
Summary
TokenCounterVerification
Using local .NET SDK
10.0.100installed under/tmp/dotnet:PATH=/tmp/dotnet:$PATH DOTNET_ROOT=/tmp/dotnet DOTNET_CLI_TELEMETRY_OPTOUT=1 dotnet test dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj --filter TextChunkerTests-> 41 passedPATH=/tmp/dotnet:$PATH DOTNET_ROOT=/tmp/dotnet DOTNET_CLI_TELEMETRY_OPTOUT=1 dotnet format dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj --include dotnet/src/SemanticKernel.Core/Text/TextChunker.cs dotnet/src/SemanticKernel.UnitTests/Text/TextChunkerTests.cs --verify-no-changes --no-restoregit diff --check