[http-client-csharp] Normalize acronyms in operation parameter names by Copilot · Pull Request #12076 · microsoft/typespec

Copilot · 2026-09-29T21:43:35Z

Extend acronym normalization to ordinary operation parameters while preserving named-argument compatibility for exact, customized, and previously published signatures.

Naming: Reuse boundary-aware acronym rules for query/path/header/body parameters. Preserve leading camelCase (ipAddress, ipv4Address, ipv6Address) and leave serialized wire names unchanged.
Compatibility: Preserve names per signature across protocol/convenience and sync/async projections. Retain legacy iPv4/iPv6 spellings and existing property-derived and date/time parameter behavior.
References: Give each projection independent parameter instances. Keep forwarding, named arguments, spread/grouped mappings, validation, and XML documentation aligned with emitted signatures.
Regression coverage: Cover acronym boundaries, repeated and canonical spellings, exact/custom/published names, unmatched contracts, and reordered signatures.

For new, non-exact parameters without a matching published signature:

- Send(string sourceIpAddress, string targetDbName, string guestOsType)
+ Send(string sourceIPAddress, string targetDBName, string guestOSType)

Fixes [http-client-csharp] Normalize acronyms in ordinary operation parameter names #12071

azure-pipelines · 2026-09-29T21:43:58Z

Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Jorge Rangel (jorgerangel-msft)

Copilot pull the latest from main and address the merge conflicts

pkg-pr-new · 2026-10-07T17:41:11Z

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@12076

commit: d1b8024

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

github-actions · 2026-10-07T19:27:35Z

No changes needing a change description found.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Jorge Rangel (jorgerangel-msft) · 2026-10-08T18:06:35Z

Added AcronymSpreadParametersPreserveSignatures with normalized, exact, customized, and last-contract cases. It checks distinct sync/async names, an optional spread member, unchanged wire names, constructor argument order when method parameters are reordered, and forwarding of the reconstructed model through the protocol and CreateRequest methods.

🤖 Generated by Jorge's Copilot

Copilot

🟡 Changes recommended

Acronym normalization unintentionally renames client-scoped constructor and settings parameters without backward-compatibility restoration.

1 open finding

Preserve client parameter names during acronym normalization · New

What changed in this PR

Normalizes acronyms in C# operation parameter names while preserving wire names, customized signatures, and published API compatibility.

Changes:

Adds boundary-aware camelCase acronym normalization.
Keeps method projections and forwarding references independent and synchronized.
Expands compatibility and regression coverage.

File	Description
`TestProjects/Local/Sample-TypeSpec/tspCodeModel.json`	Adds acronym scenarios to generated input.
`TestProjects/Local/Sample-TypeSpec/src/Generated/SampleTypeSpecClient.RestClient.cs`	Updates generated request methods.
`TestProjects/Local/Sample-TypeSpec/src/Generated/SampleTypeSpecClient.cs`	Updates generated public methods.
`TestProjects/Local/Sample-TypeSpec/Sample-TypeSpec.tsp`	Defines integration scenarios.
`Microsoft.TypeSpec.Generator/test/Providers/TypeProviderTests.cs`	Tests type-aware contract lookup.
`Microsoft.TypeSpec.Generator/test/Providers/ParameterProviderTests.cs`	Tests normalization and metadata isolation.
`Microsoft.TypeSpec.Generator/test/Expressions/PositionalParameterReferenceExpressionTests.cs`	Tests renamed named arguments.
`Microsoft.TypeSpec.Generator/src/Utilities/BackCompatHelper.cs`	Restores published parameter names.
`Microsoft.TypeSpec.Generator/src/Snippets/Snippet.cs`	Retains parameter references in named arguments.
`Microsoft.TypeSpec.Generator/src/Shared/CSharpNameExtensions.cs`	Adds camelCase acronym normalization.
`Microsoft.TypeSpec.Generator/src/Providers/ParameterProvider.cs`	Applies normalization to input parameters.
`Microsoft.TypeSpec.Generator/src/Expressions/PositionalParameterReferenceExpression.cs`	Resolves argument names dynamically.
`ScmMethodProviderCollectionTests/AcronymSpreadParametersPreserveSignatures(LastContract)/TestClient.cs`	Supplies published spread signatures.
`ScmMethodProviderCollectionTests/AcronymSpreadParametersPreserveSignatures(Custom)/TestClient.cs`	Supplies customized spread signatures.
`Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ScmMethodProviderCollectionTests.cs`	Covers projections, spreading, and grouping.
`RestClientProviderTests/AcronymNamedArgumentsFollowReorderedProtocolSignature(Sync).cs`	Baselines sync forwarding.
`RestClientProviderTests/AcronymNamedArgumentsFollowReorderedProtocolSignature(Published)/TestClient.cs`	Supplies published reordered signatures.
`RestClientProviderTests/AcronymNamedArgumentsFollowReorderedProtocolSignature(Custom)/TestClient.cs`	Supplies customized reordered signatures.
`RestClientProviderTests/AcronymNamedArgumentsFollowReorderedProtocolSignature(Async).cs`	Baselines async forwarding.
`RestClientProviders/RestClientProviderTests.cs`	Tests request ordering and wire names.
`ClientProviderTests/TestMultipartClient_UploadMethods_OptionalBody.cs`	Updates multipart projection baseline.
`AcronymOperationParameterNamesPreserveSignatures(TypeMismatchLastContract)/TestClient.cs`	Covers incompatible published types.
`AcronymOperationParameterNamesPreserveSignatures(PrivateLastContract)/TestClient.cs`	Covers private prior signatures.
`AcronymOperationParameterNamesPreserveSignatures(Normalized).cs`	Baselines normalized forwarding.
`AcronymOperationParameterNamesPreserveSignatures(LastContract)/TestClient.cs`	Supplies legacy signatures.
`AcronymOperationParameterNamesPreserveSignatures(LastContract).cs`	Baselines legacy forwarding.
`AcronymOperationParameterNamesPreserveSignatures(DistinctLastContract)/TestClient.cs`	Supplies projection-specific names.
`AcronymOperationParameterNamesPreserveSignatures(DistinctLastContract).cs`	Baselines projection-specific forwarding.
`AcronymOperationParameterNamesPreserveSignatures(Custom)/TestClient.cs`	Supplies customized signatures.
`AcronymOperationParameterNamesPreserveSignatures(Custom).cs`	Baselines customized forwarding.
`AcronymOperationParameterNamesPreserveSignatures(CaseOnlyLastContract)/TestClient.cs`	Supplies casing variants.
`AcronymOperationParameterNamesPreserveSignatures(CaseOnlyLastContract).cs`	Baselines casing preservation.
`AcronymNamedArgumentsUseProtocolSignature(LastContract)/TestClient.cs`	Supplies published protocol names.
`AcronymNamedArgumentsUseProtocolSignature(LastContract,Sync).cs`	Baselines published sync arguments.
`AcronymNamedArgumentsUseProtocolSignature(LastContract,Async).cs`	Baselines published async arguments.
`AcronymNamedArgumentsUseProtocolSignature(Custom)/TestClient.cs`	Supplies custom protocol names.
`AcronymNamedArgumentsUseProtocolSignature(Custom,Sync).cs`	Baselines custom sync arguments.
`AcronymNamedArgumentsUseProtocolSignature(Custom,Async).cs`	Baselines custom async arguments.
`ClientProviders/ClientProviderTests.cs`	Tests signature compatibility.
`ClientModel/src/Providers/ScmMethodProviderCollection.cs`	Creates independent projection parameters.
`ClientModel/src/Providers/RestClientProvider.cs`	Creates independent request parameters.
`ClientModel/src/Primitives/ScmKnownParameters.cs`	Adds factories for signature-owned parameters.

🧠 Review effort: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…sharp-normalize-acronyms Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Copilot · 2026-10-09T16:48:19Z

Copilot pull the latest from main and address the merge conflicts

Merged the latest main into this branch cleanly; merge commit $(git rev-parse --short HEAD) includes the current main tip.

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

…t mapping Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Copilot

🟡 Changes recommended

Unmatched overloads can restore unrelated names, and optional multipart reordering can break existing custom partial signatures.

2 open findings

1 resolved since last review

Preserve client parameter names during acronym normalization

🧠 Review effort: Balanced

Copilot · 2026-10-09T18:10:06Z

Copilot overall, we should avoid having to mutate the parameters after they have already been constructed. Ideally, the renaming happens during construction time to avoid the additional complexity

Acronym normalization now happens in ParameterProvider(InputParameter) during construction; it does not mutate parameter names afterward. This was implemented in c843255b (with the client-scope exclusion added in 42385749).

…ility Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Copilot

🟡 Changes recommended

Published reordered acronym signatures and mixed acronym/date-time compatibility still have source-breaking restoration gaps.

2 open findings

2 resolved since last review

🧠 Review effort: Balanced

Jorge Rangel (jorgerangel-msft) · 2026-10-09T22:08:21Z

+                        if (matchingPrevious != null)
+                        {
+                            preservedName = matchingPrevious.Signature.Parameters.FirstOrDefault(p =>
+                                string.Equals(p.Name, inputParameter.OriginalName, StringComparison.OrdinalIgnoreCase))?.Name;


Signature comparison and reordering now use one unambiguous raw/declared/normalized identity mapping, preserving the original parameter instances and published defaults. Forwarding is updated for positional and named arguments even when optional arguments are omitted; compilation-backed same/mixed-type cases verify sync/async signatures, CreateRequest calls, convenience calls, and XML docs.

🤖 Generated by Jorge's Copilot

Jorge Rangel (jorgerangel-msft) · 2026-10-09T22:08:20Z

+                            // Acronym restoration requires a matching signature; legacy date/time renames keep their name-only fallback.
+                            var hasAcronymRename = inputParameter.Name != inputParameter.Name.NormalizeCSharpAcronyms(useCamelCase: true);
+                            if (!hasAcronymRename)
+                            {
+                                preservedName = FindPreviousParameterName(
+                                    lastContractView, inputParameter.OriginalName, method.Signature.Name);
+                            }


Date/time inputs now retain the legacy name-only fallback even when acronym normalization also applies. Added a type-changed sourceIpCreationTime regression; ordinary acronym parameters still require a matching enclosing signature.

🤖 Generated by Jorge's Copilot

…forwarding Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Copilot AI assigned Copilot and JoshLove-msft Sep 29, 2026

Copilot started work on behalf of JoshLove-msft September 29, 2026 21:44 View session

Copilot AI linked an issue Sep 29, 2026 that may be closed by this pull request

[http-client-csharp] Normalize acronyms in ordinary operation parameter names #12071

Open

microsoft-github-policy-service Bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Sep 29, 2026

Copilot AI changed the title ~~[WIP] Normalize acronyms in ordinary operation parameter names~~ [http-client-csharp] Normalize acronyms in operation parameter names Sep 29, 2026

Copilot finished work on behalf of JoshLove-msft September 29, 2026 22:27

Copilot AI requested a review from JoshLove-msft September 29, 2026 22:27

Jorge Rangel (jorgerangel-msft) reviewed Oct 7, 2026

View reviewed changes

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) October 7, 2026 17:30 View session

Copilot stopped work on behalf of Jorge Rangel (jorgerangel-msft) due to an error October 7, 2026 17:31
Execution failed: Error: Model "gpt-6-astra" is not available.

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) October 7, 2026 17:31

Jorge Rangel (jorgerangel-msft) reviewed Oct 7, 2026

View reviewed changes

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) October 7, 2026 17:37 View session

Copilot stopped work on behalf of Jorge Rangel (jorgerangel-msft) due to an error October 7, 2026 17:37
Execution failed: Error: Model "gpt-6-astra" is not available.

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) October 7, 2026 17:37

Jorge Rangel (jorgerangel-msft) reviewed Oct 7, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) October 7, 2026 17:42 View session

Copilot stopped work on behalf of Jorge Rangel (jorgerangel-msft) due to an error October 7, 2026 17:42
Execution failed: Error: Model "gpt-6-astra" is not available.

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) October 7, 2026 17:42

Copilot AI and others added 5 commits October 7, 2026 12:50

Initial plan

c3ad768

fix(http-client-csharp): normalize operation parameter acronyms safely

c843255

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

fix(http-client-csharp): retain existing date parameter compatibility

830bb8e

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

test(http-client-csharp): cover restored named argument targets

d758e39

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

refactor(http-client-csharp): address parameter naming review feedback

e6dd983

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Jorge Rangel (jorgerangel-msft) force-pushed the copilot/http-client-csharp-normalize-acronyms branch from a1a26ce to e6dd983 Compare October 7, 2026 19:23

Jorge Rangel (jorgerangel-msft) reviewed Oct 7, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Outdated

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) October 8, 2026 17:42

Jorge Rangel (jorgerangel-msft) and others added 2 commits October 8, 2026 12:50

test(http-client-csharp): cover preserved spread parameter signatures

1472ffe

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

chore: merge latest main and regenerate the sample code model

70604a8

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Jorge Rangel (jorgerangel-msft) reviewed Oct 9, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot October 9, 2026 16:38

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 16:39 View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

Comment thread ...http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ParameterProvider.cs Outdated

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 16:46 View session

Merge remote-tracking branch 'origin/main' into copilot/http-client-c…

e57a7a0

…sharp-normalize-acronyms Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Simplify operation parameter matching

ed2db4f

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 16:55

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) October 9, 2026 16:55

Jorge Rangel (jorgerangel-msft) and others added 3 commits October 9, 2026 12:11

refactor(http-client-csharp): use final callee signatures for argumen…

4d831a2

…t mapping Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

chore: integrate concurrent PR updates

cd59955

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

fix(http-client-csharp): preserve client-scoped parameter names

4238574

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot October 9, 2026 17:59

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 18:00 View session

Jorge Rangel (jorgerangel-msft) reviewed Oct 9, 2026

View reviewed changes

Comment thread ...harp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Primitives/ScmKnownParameters.cs

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs

Copilot AI reviewed Oct 9, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs

Comment thread .../http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Utilities/BackCompatHelper.cs Outdated

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 18:07 View session

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 18:10

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) October 9, 2026 18:10

fix(http-client-csharp): preserve legacy parameter signature compatib…

de8f9c6

…ility Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot October 9, 2026 20:32

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) October 9, 2026 20:33 View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

fix(http-client-csharp): preserve published parameter identities and …

d1b8024

…forwarding Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 114125be-5763-45ae-ba45-d8901f6455fd

Conversation

Copilot AI commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Sep 29, 2026

Uh oh!

Jorge Rangel (jorgerangel-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

Uh oh!

Jorge Rangel (jorgerangel-msft) commented Oct 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Jorge Rangel (jorgerangel-msft) Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

Jorge Rangel (jorgerangel-msft) Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 29, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 7, 2026 •

edited

Loading