Fix build breaks (via Library.Template update)#1472
Merged
Conversation
Real signing can only be used for official builds.
When building with the Microbuild loc plugin, the plugin tries to localize samples.dll. But that isn't prepared for localization, nor is it required.
…emplate Specifically, this merges [dd63cb0 from that repo](AArnott/Library.Template@dd63cb0).
…ry.Template into dev/andarno/fixlocbuild
ekoppel
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our builds recently started failing because binskim was including our recently added sample.dll, and because optprof runs were stale but couldn't run due to the new real signing requirement.
But optprof shouldn't need to be real-signed, and binskim should only scan shipping binaries.
I applied the fixes to Library.Template, and this then merges that in.