Skip to content

remove NotifyOfCrossThreadDependency call inside get_NoMessagePumpSynchronizationContext #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifengl merged 1 commit into from
Sep 17, 2025
Merged

remove NotifyOfCrossThreadDependency call inside get_NoMessagePumpSynchronizationContext #1486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/Microsoft.VisualStudio.Threading/JoinableTaskContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,6 @@ protected internal virtual SynchronizationContext NoMessagePumpSynchronizationCo
{
get
{
// Callers of this method are about to take a private lock, which tends
Copy link
Copy Markdown
Member

@AArnott AArnott Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could avoid the debugger hangs by adding [DebuggerBrowsable(DebuggerBrowsableState.Never)] to the property.

// to cause a deadlock while debugging because of lock contention with the
// debugger's expression evaluator. So prevent that.
Debugger.NotifyOfCrossThreadDependency();

return NoMessagePumpSyncContext.Default;
}
}
Expand Down