nes: patch: fix: don't yield malformed edits on fetch fail/cancellation#4904
Merged
nes: patch: fix: don't yield malformed edits on fetch fail/cancellation#4904
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Xtab “custom diff patch” streaming path to stop emitting edits once the underlying chat fetch has failed or been cancelled, preventing consumers from applying malformed/partial edits.
Changes:
- Extend
XtabCustomDiffPatchResponseHandler.handleResponsewith an optionalgetFetchFailurecallback and early-return when it reports a failure/cancellation. - Wire the handler up from
XtabProviderby passing a callback derived fromchatResponseFailure. - Add unit tests for cancellation/failure behavior in the custom diff patch response handler.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/extension/xtab/node/xtabCustomDiffPatchResponseHandler.ts | Adds fetch-failure detection hook to stop yielding edits on cancellation/failure. |
| src/extension/xtab/node/xtabProvider.ts | Passes fetch-failure mapping callback into the custom diff patch response handler. |
| src/extension/xtab/test/node/xtabCustomDiffPatchResponseHandler.spec.ts | Adds tests intended to validate stopping edit emission on fetch failure/cancellation. |
aeschli
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.