Fix: Do not activate on pseudoterminals

[edvilme]

This pull request introduces a new utility function to consistently determine when terminal activation should be skipped, and refactors related logic throughout the codebase to use this function. The main goal is to improve reliability and maintainability by centralizing the logic for skipping activation of certain terminals (such as hidden or PTY-based extension terminals).

Terminal activation skip logic improvements:

• Added a new function shouldSkipTerminalActivation in src/features/terminal/utils.ts to centralize the logic for skipping activation for terminals that are hidden from the user or are PTY-based extension terminals.
• Refactored TerminalManagerImpl in src/features/terminal/terminalManager.ts to use shouldSkipTerminalActivation instead of directly checking terminal options in multiple places, ensuring consistent behavior when opening or activating terminals. [1] [2] [3] [4]
• Updated TerminalActivationImpl in src/features/terminal/terminalActivationState.ts to use the new skip logic, preventing activation for terminals that meet the skip criteria. [1] [2]

Other changes:

• Cleaned up imports in src/features/terminal/terminalManager.ts and src/features/terminal/utils.ts to remove unused TerminalOptions and add ExtensionTerminalOptions where needed. [1] [2]

Fixes #1482

[anthonykim1]

Would be great if we can avoid using unknown or any as much as possible

[anthonykim1]

Thanks for the PR!

PTY-based extension terminals

@edvilme Have you / can you please test this with a sample extension that creates a custom PTY terminal? That seems closest to the original repro path, where the terminal is opened by another extension after activation.

[edvilme]

Repro (from Q# Extension)

1. Install quantim.qsharp-lang-vscode (v. 1.27.0)
2. Open a workspace with a .venv in it
3. Confirm virtual env activation happens in PS terminal
4. Create foo.qs file (use snippet suggestions)
5. Run program

Issue

QDK terminal keeps closing by itself, it should remain open

[edvilme]

Thanks for the PR!

PTY-based extension terminals

@edvilme Have you / can you please test this with a sample extension that creates a custom PTY terminal? That seems closest to the original repro path, where the terminal is opened by another extension after activation.

Tested, now working

[anthonykim1]

Thanks @edvilme
Might need to tweak the test to opt out activation for extension contributed custom pty terminals, and remove unknowns/any from #1509 (comment) but looks good otherwise