sessions: Remove bracket navigation keybindings - #332029
Draft
roblourens wants to merge 1 commit into
Draft
Conversation
Remove the macOS Shift+Cmd+Bracket shortcuts for navigating between sessions while preserving the existing alternate bindings. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes conflicting macOS bracket shortcuts for session navigation while preserving existing alternatives.
Changes:
- Removes
Shift+Cmd+[andShift+Cmd+]. - Retains
Cmd+Alt+Left/RightandAlt+Up/Down.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts |
Updates macOS session navigation keybindings. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Mohammad javad Dianat (dianatofficial)
left a comment
Mohammad javad Dianat (dianatofficial)
left a comment
There was a problem hiding this comment.
Looks good. Error handling is solid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shift+Cmd+[shortcut for navigating to the previous sessionShift+Cmd+]shortcut for navigating to the next sessionCmd+Alt+Left/RightandAlt+Up/DownbindingsValidation
npm run eslint -- src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.tsnpm run compile-clientnpm run hygiene(Written by Copilot)