Make browser ownership mutable - #332038
Draft
Kyle Cutler (kycutler) wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes integrated browser ownership mutable across main and renderer processes.
Changes:
- Adds owner mutation APIs and change events.
- Mirrors ownership changes in renderer models.
- Ensures newly opened child views inherit current ownership.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/browserView/common/browserView.ts |
Adds mutable model ownership. |
src/vs/platform/browserView/electron-main/browserViewMainService.ts |
Exposes ownership mutation and forwards child ownership. |
src/vs/platform/browserView/electron-main/browserView.ts |
Stores mutable ownership and emits changes. |
src/vs/platform/browserView/common/browserView.ts |
Extends the service contract. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
Kyle Cutler (kycutler)
marked this pull request as ready for review
August 21, 2026 22:12
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 21, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Joaquín Ruales (@jruales)Matched files:
|
Kyle Cutler (kycutler)
force-pushed
the
kycutler/mutableowner
branch
from
August 21, 2026 22:22
37f0000 to
5776eb9
Compare
Kyle Cutler (kycutler)
marked this pull request as draft
August 21, 2026 22:38
Mohammad javad Dianat (dianatofficial)
left a comment
Mohammad javad Dianat (dianatofficial)
left a comment
There was a problem hiding this comment.
Well done. The optimization reduces unnecessary allocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.