Browser: never show query parameters in tab descriptions - #332058
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents integrated-browser tab descriptions from exposing URL query parameters.
Changes:
- Strips queries and fragments from medium/long URL descriptions.
- Improves short descriptions for file URLs and adds coverage for URL verbosity.
Show a summary per file
| File | Description |
|---|---|
browserEditorInput.ts |
Updates URL description formatting. |
browserEditorInput.test.ts |
Tests HTTP and file URL descriptions. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Kyle Cutler (kycutler)
marked this pull request as ready for review
August 21, 2026 22:45
Kyle Cutler (kycutler)
enabled auto-merge (squash)
August 21, 2026 22:45
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Joaquín Ruales (@jruales)Matched files:
|
TylerLeonhardt
approved these changes
Aug 21, 2026
Joaquín Ruales (jruales)
approved these changes
Aug 21, 2026
Joaquín Ruales (jruales)
left a comment
Joaquín Ruales (jruales)
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.