Agent Host: Make debug log export best-effort - #332062
Merged
roblourens merged 2 commits intoAug 22, 2026
Merged
Conversation
Skip unavailable supplementary log sources and remove the debug-log byte limit while retaining manifest and entry-count validation.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Makes Agent Host debug-log exports best-effort and removes the previous 256 MiB limit.
Changes:
- Skips supplementary log sources that become unavailable.
- Makes ZIP size limits optional while retaining entry and manifest validation.
- Adds coverage for unavailable sources and larger artifacts.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/node/zip.ts |
Adds best-effort sources and optional size validation. |
src/vs/base/test/node/zip/zip.test.ts |
Tests best-effort ZIP behavior. |
src/vs/platform/agentHost/browser/agentHostProtocolClient.ts |
Accepts artifacts beyond 256 MiB. |
src/vs/platform/agentHost/common/agentService.ts |
Removes the size-limit constant. |
src/vs/platform/agentHost/node/agentHostDebugLogs.ts |
Removes collector size limits. |
src/vs/platform/agentHost/test/electron-browser/agentHostProtocolClient.test.ts |
Tests large protocol artifacts. |
src/vs/platform/agentHost/test/node/agentHostDebugLogs.test.ts |
Tests large collected artifacts. |
src/vs/platform/native/common/native.ts |
Extends native ZIP options and entries. |
src/vs/platform/native/electron-main/nativeHostMainService.ts |
Filters unavailable entries and handles optional limits. |
src/vs/workbench/contrib/chat/electron-browser/actions/exportAgentHostDebugLogsService.ts |
Enables best-effort supplementary logs without a size cap. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Balanced
roblourens
marked this pull request as ready for review
August 21, 2026 23:06
roblourens
enabled auto-merge (squash)
August 21, 2026 23:06
Anthony Kim (anthonykim1)
approved these changes
Aug 21, 2026
Ben Villalobos (benvillalobos)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
./scripts/test.sh --run src/vs/base/test/node/zip/zip.test.ts --run src/vs/platform/agentHost/test/node/agentHostDebugLogs.test.ts --run src/vs/platform/agentHost/test/electron-browser/agentHostProtocolClient.test.ts(115 passing)npm run typecheck-client(Written by Copilot)