agentHost: fix state manager test access - #332086
Closed
roblourens wants to merge 1 commit into
Closed
Conversation
Use the AgentService test composition seam after the service graph was sealed. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates migration-race tests to access the state manager through the test composition seam, preserving AgentService encapsulation.
Changes:
- Replaces two direct
stateManageraccesses withgetStateManager(svc).
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/test/node/agentService.test.ts |
Uses the established test state-manager accessor in two migration tests. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentServiceservice graph introduced by Adopt a sealed Agent Host service graph #332036Testing
npm run compilenpm run hygienenpm run typecheck-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/agentService.test.ts --grep "waits for initial provider migration|a session the catalog migration will register"(Written by Copilot)