Skip to content

Address flaky test #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelgrinberg merged 1 commit into from
May 21, 2026
+3 −3
Merged

Address flaky test #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/async/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@ async def schedule_ping_and_sleep():

async def test_schedule_ping_twice(self):
mock_server = self._get_mock_server()
mock_server.ping_interval = 0.01
mock_server.ping_interval = 0.1
s = async_socket.AsyncSocket(mock_server, 'sid')
s.send = mock.AsyncMock()

async def schedule_ping_and_sleep():
s.schedule_ping()
await asyncio.sleep(0.05)
await asyncio.sleep(0.2)

s.schedule_ping()
assert s.last_ping is None
Expand Down
2 changes: 1 addition & 1 deletion tests/common/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def test_schedule_ping_twice(self):
assert s.last_ping is None
time.sleep(0.01)
s.schedule_ping()
time.sleep(0.1)
time.sleep(0.2)
assert s.last_ping is not None
assert s.send.call_count == 1

Expand Down
Loading