Feature/s3tables #198
Draft
Feature/s3tables #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces S3 Tables support to the MinIO Rust SDK, implementing a comprehensive Apache Iceberg REST Catalog client with warehouse management, namespace operations, table/view lifecycle, and query planning capabilities.
Key changes:
- New
s3tablesmodule with full Iceberg REST API implementation - Builder pattern for all operations with typed-builder support
- Pluggable authentication (SigV4, Bearer, NoAuth)
- Performance optimizations (signing key cache, zero-copy streaming, multimap improvements)
- Enhanced checksum support (CRC32/C, CRC64-NVME, SHA1/256)
Reviewed changes
Copilot reviewed 79 out of 221 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/s3tables/builders/*.rs | Request builders for Tables API operations (warehouses, namespaces, tables, views) |
| src/s3tables/auth.rs | Authentication providers for different catalog backends (SigV4, Bearer, NoAuth) |
| src/s3tables/advanced/*.rs | Advanced operations for direct Iceberg metadata manipulation |
| src/s3/utils.rs | Checksum utilities (CRC32/C/64, SHA1/256) for data integrity verification |
| src/s3/signer.rs | Signing key cache for performance optimization |
| src/s3/client/mod.rs | HTTP/2 support, connection pooling, fast-path GET, region lookup skip |
| src/s3/multimap_ext.rs | Optimized header canonicalization (regex removal, pre-allocation) |
| examples/s3tables/*.rs | Example programs and stress tests for Tables API |
Comments suppressed due to low confidence (1)
src/s3/client/mod.rs:1
- This TODO comment in test code should either be addressed or removed. If the test is known to be broken or unnecessary, it should be fixed or deleted rather than left with an unresolved TODO.
// MinIO Rust Library for Amazon S3 Compatible Cloud Storage
HJLebbink
force-pushed
the
feature/s3tables
branch
4 times, most recently
from
fdd77b6 to
066d0ac
Compare
HJLebbink
force-pushed
the
feature/s3tables
branch
20 times, most recently
from
53221cb to
781b702
Compare
HJLebbink
force-pushed
the
feature/s3tables
branch
16 times, most recently
from
e36e0c1 to
1b849d2
Compare
HJLebbink
force-pushed
the
feature/s3tables
branch
8 times, most recently
from
fb5e027 to
19a2eca
Compare
Implements the MinIO S3 Tables API for Iceberg table operations: - TablesClient for managing warehouses, namespaces, and tables - Full Iceberg REST catalog API support - DataFusion integration for query pushdown (optional feature) - Table scan planning and execution - Advanced operations: commit, rename, multi-table transactions
HJLebbink
force-pushed
the
feature/s3tables
branch
from
19a2eca to
8a5ede1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.