Repository navigation
Conversation
Move broadlink_cli and broadlink_discovery into broadlink.cli with main() functions so they install via pip or uv tool install. The scripts in cli/ remain as thin wrappers.
Provide CLI tools as console_scripts entry points
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I really like using uv(and uvx) for accessing python tools without making a full installation. I noticed this repo contains a library and cli combined but the installation process for the CLI is a separate step after installing the library. This seemed a bit inconvenient since both pip and uv can install CLI tools.
Proposed change
Implement packaging for CLI tools by:
Type of change
Additional information
I verified this changed by:
Starting with my workstation not having the library installed yet.
Then, I installed the package directly from my git repo using:
uv tool install git+https://github.com/cyberrkni/python-broadlink/Finally, I used the installed tools to ensure they worked. I used the learn function writing to a file for this.
Checklist