Fix pre-commit call in SPEC0 action #13609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsbinns
changed the title
larsoner
reviewed
Jan 26, 2026
| - name: Run pre-commit hooks to update other files | ||
| run: | | ||
| pip install pre-commit | ||
| pre-commit run --all |
Member
There was a problem hiding this comment.
Restore with || true?
And if you add pr: to the on: block above we can see it make an attempt here, then remove, then merge, then trigger on main with workflow_dispatch
tsbinns
changed the title
Contributor
Author
|
@larsoner, yeah the |
larsoner
reviewed
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13608
What does this implement/fix?
Remove
pre-commitcall in SPEC0 action that caused it to fail when updates to minimum versions were made.