-
Notifications
You must be signed in to change notification settings - Fork 612
Add support for v0.1.11 client conformance tests #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
When I rebase onto the mdk/client-conformance-v0.1.11, which adds support to run all the v0.1.11 tests, I still get 5 errors:
@copilot please rebase onto that branch and then fix these and any other errors. |
8adee2d to
23b3136
Compare
|
@halter73, please pay careful attention to all the auth stuff. That was mostly all copilot. |
| try | ||
| int attempt = 0; | ||
|
|
||
| while (attempt < _options.MaxReconnectionAttempts && !cancellationToken.IsCancellationRequested) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@halter73 is MaxReconnectionAttempts the right name? It seems to actually be maximum number of connection attempts (including the initial one) rather than reconnection attempts (excluding the initial one)?
77ee750 to
9deb100
Compare

Adds SDK support required to pass v0.1.11 MCP conformance tests. Six client tests were failing due to missing OAuth features and SSE reconnection support.
OAuth Provider Changes (
ClientOAuthProvider.cs)token_endpoint_auth_methods_supportedfrom server metadata. Useclient_secret_basic(HTTP Basic auth) when supported, fall back toclient_secret_postclient_credentialsflow for machine-to-machine auth when server advertises it and no redirect delegate is configuredClientIdandClientSecretare providedinsufficient_scoperetries (max 3) to prevent infinite loops on 403 responsesSSE Transport Changes (
SseClientSessionTransport.cs)Last-Event-IDand send it on reconnection attemptsConformance Server Fixes
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.