Repository navigation
Pin pdfjs-dist to 5.4.530 in pdf-server - #789
Merged
Merged
Conversation
The ^5.0.0 range lets a fresh install of @modelcontextprotocol/server-pdf resolve pdfjs-dist 5.7.x, which is affected by GHSA-hq66-cqwq-w95j (arbitrary JavaScript execution when opening a crafted PDF; fixed only in 6.2.108). The lockfile and CI already use 5.4.530, which is outside the affected range (5.6.83 to 6.2.108), so pin exactly that version.
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-preact
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-solid
@modelcontextprotocol/server-basic-svelte
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-basic-vue
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-debug
@modelcontextprotocol/server-lazy-auth
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
Merged
ochafik
added a commit
that referenced
this pull request
Sep 25, 2026
Patch release that ships the exact pdfjs-dist pin for @modelcontextprotocol/server-pdf (#789), so fresh installs no longer resolve a pdfjs-dist version affected by GHSA-hq66-cqwq-w95j.
|
This is gas |
45 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@modelcontextprotocol/server-pdfdeclarespdfjs-dist: ^5.0.0, so a fresh install resolves the newest 5.x (currently 5.7.284). That release is affected by GHSA-hq66-cqwq-w95j / CVE-2026-16633 (arbitrary JavaScript execution when opening a crafted PDF), which covers pdfjs-dist 5.6.83 up to 6.2.108.This pins the exact version the lockfile and CI already use, 5.4.530, which is outside the affected range. Node support does not change:
server-pdfkeepsengines.node >=20(pdfjs-dist 5.4.530 itself declares>=20.16.0 || >=22.3.0, as before).Moving to pdf.js 6 is a larger change (it needs Node 22.13+ and API changes in both the server and the viewer), so it can follow separately.
Test plan
examples/pdf-server/package.jsonand the matching workspace entry inpackage-lock.json. The lockfile already resolvedpdfjs-dist@5.4.530, so no installed code changes.npm ciinstallspdfjs-dist@5.4.530, andnpm packofexamples/pdf-servershows"pdfjs-dist": "5.4.530"withengines.nodestill>=20.build:all, prettier) passes; the full suite is left to CI on this PR.