fix(client): keep field descriptions visible#1468
Open
go165 wants to merge 1 commit into
Open
Conversation
shapkarin
reviewed
Jun 17, 2026
| @@ -519,6 +533,11 @@ const AppsTab = ({ | |||
| <Textarea | |||
| id={key} | |||
| placeholder={prop.description} | |||
There was a problem hiding this comment.
I'm not quite sure we need still need a description as a placeholder. After this PR, the description is shown below and empty areas display it twice.
| @@ -564,6 +583,11 @@ const AppsTab = ({ | |||
| type="number" | |||
| id={key} | |||
| placeholder={prop.description} | |||
| return ( | ||
| <p | ||
| id={id} | ||
| className="mt-1 text-xs text-muted-foreground whitespace-pre-wrap" |
There was a problem hiding this comment.
We could use the same text size as the placeholder so the text is easier to see.
Suggested change
| className="mt-1 text-xs text-muted-foreground whitespace-pre-wrap" | |
| className="mt-1 text-sm text-muted-foreground whitespace-pre-wrap" |
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1401.
Summary
Testing
npm test -- --runTestsByPath client/src/components/__tests__/ToolsTab.test.tsx client/src/components/__tests__/AppsTab.test.tsx --runInBandThis is a source-only frontend PR; no deployment was performed.