[Server] refactor: extract formatters into dedicated classes #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0ipso
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
Member
|
Please sign your commits & I can merge :) |
chr-hertel
changed the title
Split formatting logic from Reference classes into dedicated formatter classes: - ToolResultFormatter: Formats tool execution results into Content items - PromptResultFormatter: Formats prompt results into PromptMessage items - ResourceResultFormatter: Formats resource results into ResourceContents items This refactor: - Eliminates 122 lines of code duplication between ResourceReference and ResourceTemplateReference (identical formatting logic) - Improves code organization by separating formatting concerns from capability reference management - Makes formatters independently testable and reusable - Reduces Reference classes by ~450 lines while maintaining all functionality Changes: - Create src/Capability/Formatter/* with three formatter classes - Update Reference classes to delegate to formatters instead of inline logic - Add comprehensive test coverage for all formatter classes - All existing tests pass; no behavioral changes
e0ipso
force-pushed
the
refactor/extract-formatters
branch
from
d41fa09 to
4b65a03
Compare
Contributor
Author
|
@chr-hertel thanks for the review! I have rebased the commits into a single signed commit. |
chr-hertel
approved these changes
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split formatting logic from Reference classes into dedicated formatter classes:
This refactor is a spin-off of #180 that:
Motivation and Context
This will be needed to avoid code duplication in the upcoming runtime providers.
How Has This Been Tested?
Since this is a refactor, passing automated tests should be enough.
Breaking Changes
None.
Types of changes
Checklist