fix: clear() wiping dynamically registered tools by tracking discovered state on references#251
Open
soyuka wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: clear() wiping dynamically registered tools by tracking discovered state on references#251soyuka wants to merge 1 commit intomodelcontextprotocol:mainfrom
soyuka wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
soyuka
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
soyuka
force-pushed
the
fix/clear
branch
2 times, most recently
from
01d2107 to
8e7853b
Compare
…ed state on references clear() previously removed all non-manual elements, which destroyed dynamically registered tools when setDiscoveryState() was called on the next request cycle. Add isDiscovered flag to ElementReference so clear() only removes elements that were imported via setDiscoveryState(), preserving both manual and dynamic registrations.
chr-hertel
reviewed
Mar 9, 2026
Member
There was a problem hiding this comment.
was it on purpose to add a new test class here instead of extending the existing one? a bit confusing to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clear() previously removed all non-manual elements, which destroyed dynamically registered tools when setDiscoveryState() was called on the next request cycle. Add isDiscovered flag to ElementReference so clear() only removes elements that were imported via setDiscoveryState(), preserving both manual and dynamic registrations.